Skip to content

fix(slack): paginate v2 conversation listing - #7396

Merged
TheodoreSpeaks merged 5 commits into
stagingfrom
fix/slack-v2-pagination
Sep 7, 2026
Merged

fix(slack): paginate v2 conversation listing#7396
TheodoreSpeaks merged 5 commits into
stagingfrom
fix/slack-v2-pagination

Conversation

@TheodoreSpeaks

@TheodoreSpeaks TheodoreSpeaks commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • follow Slack conversation cursors across a bounded number of provider pages, including filtered short pages
  • expose page caps, continuation state, and fail-fast pagination validation in the Slack v2 block
  • move conversation listing behind the registered internal tool operation boundary

Type of Change

  • Bug fix

Testing

  • bun run lint
  • bun run check:audits

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added or updated
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel

vercel Bot commented Sep 2, 2026 •
edited
Loading

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
docs Ready Ready Preview Sep 7, 2026 7:37pm UTC

Request Review

@greptile-apps

greptile-apps Bot commented Sep 2, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR updates Slack v2 conversation listing to follow provider cursors within bounded page and result limits while exposing continuation metadata.

  • Adds bounded multi-page retrieval with repeated-cursor protection and a 10,000-conversation cap.
  • Registers conversation listing behind the internal tool-operation boundary.
  • Adds page-size, page-cap, cursor, and continuation handling to the Slack block and generated metadata.
  • Documents the revised pagination contract and adds regression coverage for optional pagination defaults.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed
Filename Overview
apps/sim/lib/internal/slack/operations/list-conversations.ts Implements validated, bounded Slack cursor pagination and correctly normalizes absent, null, and blank optional pagination values.
apps/sim/blocks/blocks/slack.ts Exposes and validates conversation page size, maximum pages, and resume cursor while preserving documented defaults.
apps/sim/lib/internal/slack/execute-tool.ts Routes Slack conversation listing through the registered internal tool-operation implementation.
apps/sim/tools/slack/list_channels.ts Updates the Slack list-channels tool contract and pagination limits for bounded multi-page retrieval.

Reviews (5): Last reviewed commit: "fix(slack): drain conversation paginatio..." | Re-trigger Greptile

greptile-apps[bot]
greptile-apps Bot reviewed Sep 2, 2026
View reviewed changes
Comment thread apps/sim/lib/internal/slack/operations/list-conversations.ts Outdated
@TheodoreSpeaks

TheodoreSpeaks commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

@TheodoreSpeaks

TheodoreSpeaks commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete.

@TheodoreSpeaks

TheodoreSpeaks commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

@TheodoreSpeaks

TheodoreSpeaks commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Sep 2, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 13 files

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread apps/sim/blocks/blocks/slack.ts Outdated
@TheodoreSpeaks

TheodoreSpeaks commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

@TheodoreSpeaks

TheodoreSpeaks commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Sep 2, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 13 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@TheodoreSpeaks
TheodoreSpeaks force-pushed the fix/slack-v2-pagination branch from 238a086 to 8656228 Compare September 7, 2026 19:13
@TheodoreSpeaks

TheodoreSpeaks commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator Author

@greptile

@TheodoreSpeaks

TheodoreSpeaks commented Sep 7, 2026

Copy link
Copy Markdown
Collaborator Author

@cubic-dev-ai review this PR

@cubic-dev-ai

cubic-dev-ai Bot commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

@cubic-dev-ai review this PR

@TheodoreSpeaks I have started the AI code review. It will take a few minutes to complete.

cubic-dev-ai[bot]
cubic-dev-ai Bot reviewed Sep 7, 2026
View reviewed changes

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 13 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@TheodoreSpeaks
TheodoreSpeaks merged commit 04322e0 into staging Sep 7, 2026
31 checks passed
@waleedlatif1 waleedlatif1 mentioned this pull request Sep 7, 2026
Merged
@waleedlatif1
waleedlatif1 deleted the fix/slack-v2-pagination branch September 7, 2026 20:30
@waleedlatif1 waleedlatif1 mentioned this pull request Sep 8, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments
@cubic-dev-ai cubic-dev-ai[bot] cubic-dev-ai[bot] left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@TheodoreSpeaks